Add CI to run the tests for Go #1440

tenzen-y · 2021-10-07T15:44:36Z

Signed-off-by: tenzen-y [email protected]

Add CI to run the tests for Go using GitHub Actions.

resolves: #1436

/assign
/cc @Jeffwan

Signed-off-by: tenzen-y <[email protected]>

tenzen-y · 2021-10-07T16:32:50Z

/assign @Jeffwan

Signed-off-by: tenzen-y <[email protected]>

tenzen-y · 2021-10-07T16:49:31Z

Is it possible to change the repository name in coveralls.io from tf-operator to training-operator?

.github/workflows/test-go.yaml

pkg/controller.v1/mxnet/mxjob_controller.go

pkg/controller.v1/tensorflow/tfjob_controller.go

.github/workflows/test-go.yaml

Jeffwan · 2021-10-07T18:44:45Z

Is it possible to change the repository name in coveralls.io from tf-operator to training-operator?

@tenzen-y you mean migrate historical data? Seem training-operator has been synced there https://coveralls.io/github/kubeflow/training-operator. I doubt we can migrate previous data or not.

Jeffwan · 2021-10-07T18:46:29Z

em.. seems after the rename, prow testing is disabled for some reason.
/cc @andreyvelich @kubeflow/wg-training-leads

andreyvelich · 2021-10-07T19:56:33Z

em.. seems after the rename, prow testing is disabled for some reason. /cc @andreyvelich @kubeflow/wg-training-leads

Yes, we should merge this: kubeflow/testing#967.
Let's try to merge it and see if prow will use the new repo ?

andreyvelich

Thank you for this enhancement @tenzen-y!
I left few comments.

.github/workflows/test-go.yaml

tenzen-y · 2021-10-08T05:37:52Z

Is it possible to change the repository name in coveralls.io from tf-operator to training-operator?

@tenzen-y you mean migrate historical data? Seem training-operator has been synced there https://coveralls.io/github/kubeflow/training-operator. I doubt we can migrate previous data or not.

Thank you for looking into coveralls. @Jeffwan

Signed-off-by: tenzen-y <[email protected]>

Jeffwan · 2021-10-08T16:14:50Z

/test

aws-kf-ci-bot · 2021-10-08T16:14:57Z

@Jeffwan: The /test command needs one or more targets.
The following commands are available to trigger jobs:

/test kubeflow-training-operator-presubmit

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tenzen-y · 2021-10-08T16:19:42Z

/test kubeflow-training-operator-presubmit

Signed-off-by: tenzen-y <[email protected]>

Jeffwan · 2021-10-08T16:26:17Z

@tenzen-y CI still needs some changes

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 720, in <module>
    final_result = main()
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 710, in main
    return run(args, file_handler)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 338, in run
    ks_cmd = ks_util.get_ksonnet_cmd(w.app_dir)
  File "/src/kubeflow/testing/py/kubeflow/testing/ks_util.py", line 46, in get_ksonnet_cmd
    with open(app_yaml_file) as app_yaml:
FileNotFoundError: [Errno 2] No such file or directory: '/src/kubeflow/tf-operator/test/workflows/app.yaml'

tenzen-y · 2021-10-08T16:30:07Z

@tenzen-y CI still needs some changes

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 720, in <module>
    final_result = main()
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 710, in main
    return run(args, file_handler)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 338, in run
    ks_cmd = ks_util.get_ksonnet_cmd(w.app_dir)
  File "/src/kubeflow/testing/py/kubeflow/testing/ks_util.py", line 46, in get_ksonnet_cmd
    with open(app_yaml_file) as app_yaml:
FileNotFoundError: [Errno 2] No such file or directory: '/src/kubeflow/tf-operator/test/workflows/app.yaml'

@Jeffwan I fixed this error in e65a9fe.

Jeffwan · 2021-10-08T16:31:07Z

We need to fix test path as well.

https://argo.kubeflow-testing.com/workflows/kubeflow-test-infra/kubeflow-training-operator-presubmit-v1-1440-e65a9fe-6704-8145?tab=workflow&nodeId=kubeflow-training-operator-presubmit-v1-1440-e65a9fe-6704-8145-1907657365

Jeffwan · 2021-10-08T16:32:47Z

Can you help update tf reference here? (skip testServerImage)

tenzen-y · 2021-10-08T16:35:23Z

Can you help update tf reference here? (skip testServerImage)

Sure.

Signed-off-by: tenzen-y <[email protected]>

tenzen-y · 2021-10-08T16:55:20Z

Maybe, I think fixed the tests.
WDYT?@Jeffwan

https://argo.kubeflow-testing.com/workflows/kubeflow-test-infra/kubeflow-training-operator-presubmit-v1-1440-43927c5-6784-46f6?tab=workflow

Jeffwan · 2021-10-08T18:04:27Z

Great! @tenzen-y You make it! changes look good to me. hold it for one day for other reviewers @andreyvelich @kubeflow/wg-training-leads

/lgtm
/approve
/hold

terrytangyuan

This is great. Thank you for your contribution!

google-oss-robot · 2021-10-08T18:06:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Jeffwan,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Jeffwan · 2021-10-08T18:22:15Z

Got approval from Terry and we can merge this.

/unhold

tenzen-y · 2021-10-08T18:34:02Z

Thanks for the review! @Jeffwan @andreyvelich @terrytangyuan

google-oss-robot assigned tenzen-y Oct 7, 2021

google-oss-robot added the do-not-merge/work-in-progress label Oct 7, 2021

google-oss-robot requested a review from Jeffwan October 7, 2021 15:44

google-oss-robot added the size/L label Oct 7, 2021

add test for Go to CI

ae72f61

Signed-off-by: tenzen-y <[email protected]>

tenzen-y force-pushed the issue-1436-add-go-test-to-ci branch from ed99fe8 to ae72f61 Compare October 7, 2021 15:47

tenzen-y added 2 commits October 8, 2021 00:59

fix golangci-lint errors

8157205

Signed-off-by: tenzen-y <[email protected]>

fix Go test

4726498

google-oss-robot assigned Jeffwan Oct 7, 2021

tenzen-y changed the title ~~[WIP] Add CI to run the tests for Go~~ Add CI to run the tests for Go Oct 7, 2021

google-oss-robot removed the do-not-merge/work-in-progress label Oct 7, 2021

fix coverage report file name

5f2a2f3

Signed-off-by: tenzen-y <[email protected]>

Jeffwan reviewed Oct 7, 2021

View reviewed changes

.github/workflows/test-go.yaml Show resolved Hide resolved

pkg/controller.v1/mxnet/mxjob_controller.go Show resolved Hide resolved

pkg/controller.v1/tensorflow/tfjob_controller.go Show resolved Hide resolved

.github/workflows/test-go.yaml Show resolved Hide resolved

google-oss-robot requested review from andreyvelich and a team October 7, 2021 18:46

andreyvelich reviewed Oct 7, 2021

View reviewed changes

.github/workflows/test-go.yaml Outdated Show resolved Hide resolved

.github/workflows/test-go.yaml Show resolved Hide resolved

tenzen-y added 3 commits October 8, 2021 14:52

use Go 1.17

74b9021

Signed-off-by: tenzen-y <[email protected]>

fix error comments

3531bc3

Signed-off-by: tenzen-y <[email protected]>

fix coverage badge in readme

92ec377

Signed-off-by: tenzen-y <[email protected]>

tenzen-y force-pushed the issue-1436-add-go-test-to-ci branch from d0b8579 to 92ec377 Compare October 8, 2021 08:01

fix e2e test

e65a9fe

Signed-off-by: tenzen-y <[email protected]>

tenzen-y added 2 commits October 9, 2021 01:39

skip testServerImage

2e0da73

Signed-off-by: tenzen-y <[email protected]>

fix e2e test PATH

43927c5

Signed-off-by: tenzen-y <[email protected]>

google-oss-robot added do-not-merge/hold lgtm approved labels Oct 8, 2021

terrytangyuan approved these changes Oct 8, 2021

View reviewed changes

google-oss-robot removed the do-not-merge/hold label Oct 8, 2021

google-oss-robot merged commit 7cdc253 into kubeflow:master Oct 8, 2021

This was referenced Oct 8, 2021

Generate a single swagger.json file for all frameworks #1437

Merged

Update links and files with the new URL #1434

Merged

tenzen-y mentioned this pull request Oct 8, 2021

Display coverage % in GitHub actions list #1442

Closed

tenzen-y deleted the issue-1436-add-go-test-to-ci branch October 8, 2021 18:34

tenzen-y mentioned this pull request Nov 27, 2021

chore: Fix GitHub Actions script #1491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI to run the tests for Go #1440

Add CI to run the tests for Go #1440

tenzen-y commented Oct 7, 2021

tenzen-y commented Oct 7, 2021

tenzen-y commented Oct 7, 2021 •

edited

Loading

Jeffwan commented Oct 7, 2021

Jeffwan commented Oct 7, 2021

andreyvelich commented Oct 7, 2021

andreyvelich left a comment

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021

aws-kf-ci-bot commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021 •

edited

Loading

Jeffwan commented Oct 8, 2021 •

edited

Loading

tenzen-y commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021 •

edited

Loading

terrytangyuan left a comment

google-oss-robot commented Oct 8, 2021

Jeffwan commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

Add CI to run the tests for Go #1440

Add CI to run the tests for Go #1440

Conversation

tenzen-y commented Oct 7, 2021

tenzen-y commented Oct 7, 2021

tenzen-y commented Oct 7, 2021 • edited Loading

Jeffwan commented Oct 7, 2021

Jeffwan commented Oct 7, 2021

andreyvelich commented Oct 7, 2021

andreyvelich left a comment

Choose a reason for hiding this comment

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021

aws-kf-ci-bot commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021 • edited Loading

Jeffwan commented Oct 8, 2021 • edited Loading

tenzen-y commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

Jeffwan commented Oct 8, 2021 • edited Loading

terrytangyuan left a comment

Choose a reason for hiding this comment

google-oss-robot commented Oct 8, 2021

Jeffwan commented Oct 8, 2021

tenzen-y commented Oct 8, 2021

tenzen-y commented Oct 7, 2021 •

edited

Loading

Jeffwan commented Oct 8, 2021 •

edited

Loading

Jeffwan commented Oct 8, 2021 •

edited

Loading

Jeffwan commented Oct 8, 2021 •

edited

Loading